[NET6] C1FlexGrid border color has changed

[NET6] C1FlexGrid border color has changed

Posted by: wknauf on 27 September 2022, 8:26 pm EST

• 

  wknauf

  • Post Options:
  • Link
    Copy
  • Jump To Answer

  Posted 27 September 2022, 8:26 pm EST - Updated 3 October 2022, 1:10 pm EST

  Hi C1,

  the C1FlexGrid border color for “Normal” style has changed, it is black now for style “Office2010Silver” (which is our default theme).

  This is the C1FlexGrid in ThemeDesigner 4.5.2:
  
  

  In Themedesigner 6, the same theme looks different:
  
  

  According to the style settings, the BorderColor should be picked from “BaseThemeProperties\Styles\Content\BorderColor”. But this does not work. If I change the base color, it is ignored. Changing the border color of the C1FlexGrid normal style works.
  
  

  

  414×788 12 KB

  Is this an intentional change or a bug?

  Best regards

  Wolfgang

• 

  wknauf

  • Post Options:
  • Link
    Copy

  Posted 27 September 2022, 8:47 pm EST

  Argghh - forget about the border color question. I just noticed that you removed most of the themes and support only those:

  ExpressionDark
  
  ExpressionLight
  
  HighContrast
  
  MacBlue
  
  MacSilver
  
  Material
  
  MaterialDark
  
  Office2016Black
  
  Office2016Colorful
  
  Office2016DarkGray
  
  Office2016Green
  
  Office2016White

  Unfortunately, our code ignored the unavailable theme and thus showed unthemed controls. And I did not notice this.

  This a big breaking change - we had “Office2010Silver” as default theme. I assume there are no plans to bring back more of the old themes?
  
  Would they even work? I assume not, because the assembly names changed - which is probably the reason why I came up with the initial border color issue.

  There is no list with all the breaking changes in .NET6? I remember having asked for this some time ago. This would be worth a sticky post in this forum.

  Best regards

  Wolfgang

• 

  kartik.dua

  

  • Post Options:
  • Link
    Copy

  Posted 28 September 2022, 8:33 pm EST

  Hi Wolfgang,

  We are getting in touch with the development team to get information on this and will get back to you with updates as soon as possible.

  [Internal Tracking ID: C1WIN-28275]

  Thanks, and Best Regards,
  
  Kartik

• 

  wknauf

  • Post Options:
  • Link
    Copy

  Posted 29 September 2022, 9:45 pm EST

  Today, we checked the new themes. The variety is a bit poor - a few light and a few dark themes - and our app does not work well with dark themes, so they are out.

  But I miss something “special” like e.g. “VS2013Red”. We used this theme to distinguish between productive and testing environments. The theme “VS2013Red” was well usable, but it had enough differences to make it obvious where you are.
  
  And of course, “Office2010Barbie” was the shocking highlight

  So, maybe you could port some more themes to .NET6?

  Or is there a way, to use old themes? Would it be sufficient to provide the old theme files and add them to C1ThemeController?
  
  I did a quick test, and at least for C1FlexGrid and C1Ribbon it worked - see attached sample, using “Office2010Barbie”.
  
  OldTheme.zip
  
  What do you think about this approach? Would it work, or is it unstable?

  Best regards

  Wolfgang

• 

  kartik.dua

  

  • Post Options:
  • Link
    Copy

  Posted 3 October 2022, 9:30 pm EST

  Hi Wolfgang,

  Unfortunately, the development team has decided not to port the legacy themes to .NET 6 as they are old and look outdated/out of style on modern OS versions. Although, the development team will improve the current themes and supply more themes for modern MS Office and Windows versions. Furthermore, we have asked them to mention these changes in the ChangeLogs.

  Also, we discussed with the development team about using the old themes in .NET 6, and as per them, you can use the themes by saving them from the .NET 4.5.2 ThemeDesigner App. You can then open the themes in .NET 6 ThemeDesigner App just to make sure that all the theme properties are working fine in the .NET 6. This way, you will be able to use the old themes in .NET 6 including the “Office2010Barbie”
  
  but please note that the themes may change externally a little bit since there is no replacement for everything in .NET 6 themes.

  Best Regards,
  
  Kartik

• 

  wknauf

  • Post Options:
  • Link
    Copy

  Posted 9 October 2022, 6:29 pm EST

  Hi Kartik,

  sorry for the delay, I was on vacation.

  Thanks for the reply.
  
  So, to clarify the process: do I have to open and save the theme in the .NET6 ThemeDesigner, or did you mention this step just to check whether the theme will work?

  Have there been already breaking changes to the themes, or will the themes currently support all features that were supported before?

  Best regards

  Wolfgang

• 

  kartik.dua

  

  • Post Options:
  • Link
    Copy

  Posted 10 October 2022, 6:14 pm EST

  Hi Wolfgang,

  It is not mandatory to open and save the theme in .NET 6 ThemeDesginer application. We mentioned this step just to check once whether the theme works correctly and whether it looks and feels fine, as there isn’t a replacement for everything in .NET 6 themes (for eg. Visual Styles have been removed from .NET 6).

  Currently, no such features have been removed from the .NET 6 C1Themes. Any changes in the future will be mentioned in the ChangeLogs. Also, the development team will
  
  mention the themes that are obsolete from .NET 4.5.2 to .NET 6 in the breaking changes.

  Best Regards,

  Kartik

• 

  wknauf

  • Post Options:
  • Link
    Copy

  Posted 10 October 2022, 10:38 pm EST

  Thanks for the reply.

  But this brings me back to my initial question ;-): why has the C1FlexGrid “Normal” style a different border color when opening the “Office2010Silver” theme in ThemeDesigner 6? Seems like the border color is not picked from the path “BaseThemeProperties\Styles\Content”, as it is configured in the theme? Changing this base style does not have an effect in C1FlexGrid.

• 

  kartik.dua

  

  • Post Options:
  • Link
    Copy

  Posted 11 October 2022, 9:47 pm EST

  Hi Wolfgang,

  This is what we were talking about earlier when we mentioned checking once whether the theme works correctly and whether it looks and feels fine. There are changes in the .NET6 C1FlexGrid internally, which might result in some properties of the Themes not taking effect similar to .NET Framework Grid.
  
  But, you can edit these .NET FW Themes using the .NET6 ThemeDesigner as per your requirement, and then use it further in your .NET6 application.

  Best Regards,

  Kartik

• 

  wknauf

  • Post Options:
  • Link
    Copy

  Posted 12 October 2022, 1:50 am EST

  Ahhh, I understand now what is happening: the default border color in the C1FlexGrid “Normal” style was changed from “Control” to “ControlDark” in the .NET6 version.
  
  See attached sample - two projects with just an empty C1FlexGrid on an form.

  C1FlexGridBorder.zip

  One more for the upcoming “breaking changes” document ;-)?

  This issue is not related to themes. Though the “Normal” style references the “BaseThemeProperties\Styles\Content” theme section, the border color is not picked from the theme.
  
  One could consider this a missing feature, but as it is the same behavior as before, I don’t complain ;-).

  Best regards

  Wolfgang

• 

  kartik.dua

  

  • Post Options:
  • Link
    Copy

  Posted 13 October 2022, 6:13 pm EST

  Hi Wolfgang,

  Apologies for the delay in response and thank you for pointing out the changes. We have shared your observation with the dev team to get their insights on it and will let you know as soon as possible.

  Best Regards,

  Kartik

• 

  kartik.dua

  

  • Post Options:
  • Link
    Copy

  Posted 19 December 2022, 4:47 pm EST

  Hi Wolfgang,

  1. As per the development team, this is an improvement in the appearance of the .NET5, .NET6 versions of C1FlexGrid. These changes are mentioned in the C1FlexGrid ChangeLog of version 2021v2(513).

  2. The “removal of legacy themes” change is mentioned in the C1Themes ChangeLog of version 2021v3(532).

  You can refer to the “ChangeLog.6.0.html” of the latest 2022v3(584) installation to see both the above.

  Thanks, and Kind Regards,

  Kartik

• 

  wknauf

  • Post Options:
  • Link
    Copy

  Posted 17 January 2023, 6:47 pm EST

  So, there are no plans to bring back more of the old themes?

  Best regards

  Wolfgang

• 

  kartik.dua

  

  • Post Options:
  • Link
    Copy

  Posted 17 January 2023, 10:47 pm EST

  Hi Wolfgang,

  Unfortunately, as per the development team, there are no plans to port old themes to .NET 6 as they look outdated and out of style on modern OS versions. Moreover, in .Net 6, the VisualStyle was removed, so there is no direct way to implement these themes in .NET 6. Also, the default control appearances have been changed to fit in style with Windows 10 and Windows 11. Considering all these points, the development team has currently no plans for porting old themes to .NET 6.

  Thanks, and Best Regards,

  Kartik

• 

  wknauf

  • Post Options:
  • Link
    Copy

  Posted 18 January 2023, 12:27 am EST

  OK. Currently, our workaround to use the old themes works. Hopefully, you don’t break them for years ;-).

  But I still suggest to add a slightly more colorful theme - the current theme set does not have much differences at least between the brighter themes, and dark themes dont’ work well with our application. We use “VS2013Red” for testing environments at customer sites, so that it is obvious for the user at first glance that you are not in production.

  Best regards

  Wolfgang

• 

  kartik.dua

  

  • Post Options:
  • Link
    Copy

  Posted 18 January 2023, 5:25 pm EST

  Hi Wolfgang,

  We completely understand your views. We have escalated an enhancement request to the development team for the same and also shared your views with them. We will let you know as soon as we have any updates from them.

  [Internal Tracking ID: C1WIN-28922]

  Best Regards,
  
  Kartik