Posted 1 September 2020, 7:30 pm EST
Hi,
I would like to point out some issues I’ve found while using @grapecity/ar-viewer npm package:
-
The jsViewer.min.css file even though it says “min” it isn’t minified. That in my opinion is a bit misleading. I don’t know if this was made by design but I guess that the contents of this file should be minified.
-
Another issue is the fact that in that same file there’s a css block with the following code:
html,
body {
width: 100%;
height: 100%;
margin: 0;
padding: 0; }
This in my opinion is incorrect because if someone tries to embed this JSViewer into their web site the body style will potentially be overridden.
In our case padding 0 messed up some of our other component styles. We removed that block of code then everything went back to normal.
This is not a criticism in any way because I think you did a really good job in general. Hope you appreciate the feedback.
Best Regards,
Ricardo Pereira
